feat(sidekick): upgrade block library to use new plugin #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-sidekickupgrade
…-sidekickupgrade
…-sidekickupgrade
…-sidekickupgrade
|
|
|
|
|
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I've got a hard coded URL in the icons.js for testing purposes, I will change it before merging.
The test URL should not be any different than on MAIN after I moved createOptimizedPicture function.
Issue
Fixes #239
Description
Test URLs
main): https://main--merative2--hlxsites.hlx.page/blogTesting Instruction
Currently I've got a hard coded URL in the icons.js for testing purposes, I will change it before merging.
Use URL 239-sidekickupgrade--merative2--hlxsites.hlx.page/tools/sidekick/library.html to view the new sidekick.
The /block-library documents were all updated to render properly with a description of the variation on the bottom of the preview area.
To test blocks and sections, go to the HTML page and when you click on a block style, there's a button to copy it. You just have to paste this into a Word doc.
To test icons, choose "icons" from the top dropdown, then click on any SVG and it will copy the :icon-name: that you can paste into a document.
authoring
There's a new line in the metadata to add when you would like to copy compound sections.
